Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Isolate changes to just hook and rename for general use #1399

Merged

Conversation

sandrahoang686
Copy link
Collaborator

@sandrahoang686 sandrahoang686 commented Jan 22, 2025

Changes:
#1398 (review)

Screenshot 2025-01-22 at 6 30 42 PM

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit a5707e3
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/679179e949f1d60009af2af7
😎 Deploy Preview https://deploy-preview-1399--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hanbyul-here hanbyul-here merged commit c2b94af into 1360-remove-veda-dependency Jan 23, 2025
9 checks passed
@hanbyul-here hanbyul-here deleted the 1360-remove-veda-dependency-fixes branch January 23, 2025 13:31
@hanbyul-here
Copy link
Collaborator

Yay thank you~ (just heads-up that there are many other places using useFeedbackModal from layout-root in case if you want to consolidate them later.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants